[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272791951 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -145,147 +188,517 @@ public void disableActiveSi

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272724945 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +193,212 @@ public boolean validateClientRack

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272693494 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272692608 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -268,24 +268,44 @@ public static class AssignmentCon

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-23 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271539596 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271098823 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -38,29 +43,34 @@ public class RackAwareTaskAssign

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271081266 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack