[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490947807 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -2496,46 +2501,81 @@ public void testGetOffsetByTi

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490941989 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -2496,46 +2501,81 @@ public void testGetOffsetByTi

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490940439 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -910,136 +913,161 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r490933197 ## File path: clients/src/main/resources/common/message/ListOffsetResponse.json ## @@ -48,7 +48,7 @@ "about": "The timestamp associated with the

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r470011774 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r470008139 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1221,28 +1226,39 @@ private DeleteGroupsResponse cre

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469964306 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -3546,12 +3594,54 @@ private void testGetOffsetsFor

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469841392 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -584,14 +590,22 @@ public void testFetchProgressWithMi

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469835182 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3732,41 +3734,43 @@ public void testListOffsets() thro

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469826866 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3973,25 +3977,38 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r467194925 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1221,28 +1226,39 @@ private DeleteGroupsResponse cre

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r467193718 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1251,15 +1267,28 @@ private ListOffsetRequest createL

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464886489 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ListOffsetRequest.java ## @@ -47,96 +42,11 @@ public static final int CONSUMER_R

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464884697 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3973,25 +3977,38 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455791789 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +895,162 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455782710 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig, // Tr

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455671951 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1077,7 +1077,7 @@ class ReplicaManager(val config: KafkaConfig, // Tr

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455671140 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -994,30 +1023,29 @@ public void onSuccess(ClientRespons

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r455669663 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +895,162 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452374925 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -994,30 +1023,29 @@ public void onSuccess(ClientRespons

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452324069 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -965,11 +994,11 @@ public void onFailure(RuntimeExcepti

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452140714 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handle