[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-08 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867531749 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-08 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867531749 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-06 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867003730 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-06 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867002955 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-06 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r866616320 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-03 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r864110167 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1139,7 +1139,7 @@ object KafkaConfig { .define(MetadataMaxRetentionMillisProp, LONG,

[GitHub] [kafka] mimaison commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-05-03 Thread GitBox
mimaison commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r864068803 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under