[GitHub] [kafka] mimaison commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-01 Thread via GitHub
mimaison commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1093412947 ## tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [kafka] mimaison commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-31 Thread via GitHub
mimaison commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1088957590 ## checkstyle/import-control.xml: ## @@ -407,7 +407,8 @@ - + + Review Comment: Can we keep the trailing spaces like all other entries

[GitHub] [kafka] mimaison commented on a diff in pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-01-24 Thread via GitHub
mimaison commented on code in PR #13136: URL: https://github.com/apache/kafka/pull/13136#discussion_r1085565198 ## checkstyle/import-control.xml: ## @@ -347,7 +347,7 @@ - Review Comment: We seem to have the trailing space everywhere else, so maybe keep it her