mimaison commented on code in PR #14172: URL: https://github.com/apache/kafka/pull/14172#discussion_r1288390063
########## tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import java.util.Objects; + +/** + * A replica log directory move state where the move is in progress. + */ +final class ActiveMoveState implements LogDirMoveState { + public final String currentLogDir; + + public final String targetLogDir; + + public final String futureLogDir; + + /** + * @param currentLogDir The current log directory. + * @param futureLogDir The log directory that the replica is moving to. + * @param targetLogDir The log directory that we wanted the replica to move to. + */ + public ActiveMoveState(String currentLogDir, String targetLogDir, String futureLogDir) { + this.currentLogDir = currentLogDir; + this.targetLogDir = targetLogDir; + this.futureLogDir = futureLogDir; + } + + @Override + public boolean done() { + return false; + } + + @Override + public boolean equals(Object o) { Review Comment: Do we need `equals()` and `hashcode()` on all these objects? ########## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ########## @@ -0,0 +1,48 @@ +/* Review Comment: Let's not include this class in this PR. At this stage it's unclear if it will be needed. If we really need it let's put it in the PR moving the tool. ########## tools/src/main/java/org/apache/kafka/tools/reassign/TerseReassignmentFailureException.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import org.apache.kafka.common.KafkaException; + +/** + * An exception thrown to indicate that the command has failed, but we don't want to + * print a stack trace. + */ +public class TerseReassignmentFailureException extends KafkaException { Review Comment: Do we need this exception? I'm assuming we should be able to reuse the existing `TerseException` since only the message is supposed to be returned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
