[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-03-08 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1460030284 Thanks @nizhikov for the update. When I run `./gradlew aggregatedJavadoc`, the generated javadoc (under `./build/docs/javadoc/`) contain all classes from mirror, so something is

[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-03-06 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1456709095 Sorry for the delay. I _think_ you technically don't necessarily need to have transitive dependencies in the classpath to compile a class. For example, it is possible to build a custom

[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402375492 The Config classes are not part of the public API. I suggested moving the interfaces without thinking too much about it, have you considered if this could break anything? -- This is

[GitHub] [kafka] mimaison commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

2023-01-24 Thread via GitHub
mimaison commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1402188145 @nizhikov Thanks for looking at this issue. I don't think we can simply enable the javadoc on the `connect:mirror` project as it will also include all public classes from that module