[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-07-19 Thread via GitHub
mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1642274928 My point is that this really contradicts the KIP. In the KIP we say "it does not work" but then we have a test that relies on the upgrade working. This is a bit counter intuitive. --

[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-07-06 Thread via GitHub
mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1623903798 Also we need to update the `LICENSE-binary` file as mentioned in https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L73-L74 -- This is an automated message from the

[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-07-05 Thread via GitHub
mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1622020208 I'm not familiar with these tests so please correct me if I'm not understanding something correctly. First, the KIP states (Compatibility, Deprecation, and Migration Plan

[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-06-20 Thread via GitHub
mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1599080971 I've not setup the system tests recently. If the provided instructions are not clear enough, let's discuss it on the dev mailing list. You can also open Jiras for the issues you

[GitHub] [kafka] mimaison commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-06-05 Thread via GitHub
mimaison commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1576955162 Thanks @clolov for the PR. I think some system tests do upgrades from previous versions to the latest. Have you checked these system tests still work with this change? -- This is an