mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-698359953
Thanks @abbccdda and @dajac for the reviews!
This is an automated message from the Apache Git Service.
To respond
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-698359953
Thanks @abbccdda and @dajac for the reviews!
This is an automated message from the Apache Git Service.
To respond
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-697885454
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-697868544
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-694867857
@abbccdda I hope you had a good time off!
Thanks for the review. I pushed an update
This is an automated mess
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-692191592
@abbccdda Gentle reminder =)
This is an automated message from the Apache Git Service.
To respond to the message,
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-675697535
@abbccdda Thanks for the reviews, can you take another look?
This is an automated message from the Apache Git Ser
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-670643947
@abbccdda I've addressed your comments, can you take another look?
This is an automated message from the Apache G
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-667010664
The test failure is unrelated. It's
`org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest >
shouldUpgradeFromEosAlphaToEosBeta[true]` again
--
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-666701712
@abbccdda Done!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-666310163
@dajac Ok, I've removed the `Optional` to `Option` changes
This is an automated message from the Apache Git Servi
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-662968116
Rebased on trunk
This is an automated message from the Apache Git Service.
To respond to the message, please log
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-659347339
Thanks @dajac for your comments, I've pushed an update.
@abbccdda Can you take a look?
This is an automate
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-656894169
Thanks @dajac for the feedback. I've pushed an update
This is an automated message from the Apache Git Service.
T
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-653096791
@dajac I've rebased on trunk
This is an automated message from the Apache Git Service.
To respond to the message,
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-651657082
The conflicts are pretty nasty. I started looking at it last week but did
not have the time (nor the courage!) to finish. I plan to take another look
this week
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-638444641
@dajac Thank for your interest. I want to merge
https://github.com/apache/kafka/pull/8311 and
https://github.com/apache/kafka/pull/8312 first. I'll take a look at them
tomorrow
17 matches
Mail list logo
