[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435589707 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435588028 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434220229 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434217796 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434217037 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -493,28 +549,45 @@ public void closeAndRecycleState()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434216773 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -493,28 +542,45 @@ public void closeAndRecycleState()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434215917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -493,28 +549,45 @@ public void closeAndRecycleState()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434215315 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434117796 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434111426 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434111426 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434110314 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433662342 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -2637,11 +2646,17 @@ private File

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433662426 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -2637,11 +2646,17 @@ private File

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433661972 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660588 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -529,11 +524,7 @@ void handleLostAll() {

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660588 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -529,11 +524,7 @@ void handleLostAll() {

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660276 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659711 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -59,14 +58,9 @@ * ||

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659955 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659277 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659175 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659050 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()