[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-12-30 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r550337598 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533555 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533429 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -97,13 +97,9 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533374 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -57,30 +59,31 @@ * @param stateDirectory the

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533205 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -16,82 +16,85 @@ */ package

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533174 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -16,82 +16,85 @@ */ package