[GitHub] [kafka] mjsax commented on a change in pull request #9461: MINOR: Clean-up streams javadoc warnings

[GitBox]

mjsax commented on a change in pull request #9461:
URL: https://github.com/apache/kafka/pull/9461#discussion_r508705351



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -184,9 +184,9 @@
      * <pre>
      * KafkaStreams streams = ... // some aggregation on value type double
      * String queryableStoreName = "storeName" // the store name should be the 
name of the store as defined by the Materialized instance
-     * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VOut>> localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.<K, 
ValueAndTimestamp<VOut>> timestampedKeyValueStore());
+     * ReadOnlyKeyValueStore&gt;K, ValueAndTimestamp&gt;VOut&lt;&lt; 
localStore = streams.store(queryableStoreName, QueryableStoreTypes.&gt;K, 
ValueAndTimestamp&gt;VOut&lt;&lt; timestampedKeyValueStore());

Review comment:
       I seem the right fix would be to add the missing `{@code }` annotation 
in L184?
   ```
   <pre>{@code
   ```
   The closing `}` is already in L190.

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -236,9 +236,9 @@
      * <pre>
      * KafkaStreams streams = ... // some aggregation on value type double
      * String queryableStoreName = "storeName" // the store name should be the 
name of the store as defined by the Materialized instance
-     * ReadOnlyKeyValueStore<K, ValueAndTimestamp<VOut>> localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.<K, 
ValueAndTimestamp<VOut>> timestampedKeyValueStore());

Review comment:
       As above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org