[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162058460 ## docs/streams/upgrade-guide.html: ## @@ -75,6 +75,20 @@ < changelogs. + +Downgrading from 3.5.x or newer version to 3.4.x or older version

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162056271 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableRepartitionMap.java: ## @@ -76,6 +79,48 @@ public boolean enableSendingOldValues(final boolean

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162055509 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +49,87 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1160948695 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +49,87 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1093821934 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +47,85 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1093813869 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -46,33 +45,40 @@ public void setIfUnset(final SerdeGetter getter) {