[GitHub] [kafka] mjsax commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-02 Thread via GitHub
mjsax commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1415043376 `TEST_CASES` is clear and also the names of the test methods are clear. It's really the code iterating over the test cases with all the loops (forward, backward) and nested if/else control

[GitHub] [kafka] mjsax commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

2023-02-01 Thread via GitHub
mjsax commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1412741570 Most of my comments are educational or nits. I merged this PR already, and if you want to address anything (feel free to ignore), let's do a follow up PR. Wanted to merge this to unblock ot