mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-773692994
Merged to `trunk`.
Congrats for getting this into the 2.8.0 release @inponomarev -- great work!
This is an
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-773692994
Merged to `trunk`.
Congrats for getting this into the 2.8.0 release @inponomarev -- great work!
This is an
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-772719099
Ah I see -- well, we do have from flaky tests, so nothing to worry about I
guess. The last run timed out, so I retriggered the build. However, I could
build it locally with
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-772153631
Wait failure do you see? Seem Jenkins in still running.
This is an automated message from the Apache Git Service.
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-768478775
@inponomarev the failing tests seems to be due to a known issue that was
fixed via https://github.com/apache/kafka/pull/9768
Can you rebase your PR to pickup the fix so we
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-759130287
@vvcephei -- hope you are also ok with the proposed changes to the KIP as
per the PR description on top:
https://github.com/apache/kafka/pull/9107#issuecomment-666749809
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752730961
Maybe I miss-understood you question. I thought the build fails because we
are using some deprecated method -- for this case, we can make the build pass
by suppressing the warning.
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752241886
To make the build pass, for now, it should be sufficient to just deprecate
the method via `@nowarn("cat=deprecation")` -- But it seems we should update
the Scala API, too. If you
