[GitHub] [kafka] mjsax commented on pull request #9513: MINOR: improve `null` checks for headers

2020-10-29 Thread GitBox
mjsax commented on pull request #9513: URL: https://github.com/apache/kafka/pull/9513#issuecomment-719085653 > However, it may be overkill since users don't create ConsumerRecord. Yeah, I tend to agree. Would not hurt to add it, but should not be strictly necessary. Will merge this

[GitHub] [kafka] mjsax commented on pull request #9513: MINOR: improve `null` checks for headers

2020-10-28 Thread GitBox
mjsax commented on pull request #9513: URL: https://github.com/apache/kafka/pull/9513#issuecomment-718125704 @chia7712 Good call about `ConnectHeaders`. I am not sure what we would need to change in `ConsumerRecord` though? Can you elaborate? @showuon: what PR are you talking about?