mukkachaitanya commented on code in PR #13361:
URL: https://github.com/apache/kafka/pull/13361#discussion_r1133500395
##########
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##########
@@ -561,6 +561,9 @@ public void run() {
}
} catch (Throwable t) {
log.error("Unexpected exception in {}", this, t);
+ // resume the thread in case of any unexpected exception
encountered
+ thread = new WorkThread();
+ thread.start();
Review Comment:
It might not be an acceptable solution to restart forever. However, if we
were to retry we could keep using the same thread, and need not spawn a new
thread. We have precedence for retrying for `RetriableException` and
`TimeoutException` since the thread itself is stateless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
