[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571253465 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571173703 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import org.apache.kafka.common.message.UpdateMetadataRequestData

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571173506 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import org.apache.kafka.common.message.UpdateMetadataRequestData

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571163776 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -485,7 +494,7 @@ class MetadataCacheTest { @Test Review comment:

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571163226 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -37,7 +36,15 @@ object MetadataBroker { endPoint.name() ->

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571161027 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import org.apache.kafka.c

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571145320 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import org.apache.kafka.common.message.UpdateMetadataRequestData

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571140218 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import org.apache.kafka.common.message.UpdateMetadataRequestData

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571139784 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import org.apache.kafka.common.message.UpdateMetadataRequestData

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571138962 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import org.apache.kafka.c

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r570451366 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialBrok

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-04 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r570474971 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialBrok

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-04 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r570474971 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialBrok

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-04 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r570451366 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialBrok