[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r462364719 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -366,225 +255,128 @@ public FetchResponse(Errors error,

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r459499911 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r458382935 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r457546281 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r457546281 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r457416269 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r457416269 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456730580 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2397,6 +2460,9 @@ private String fieldDefault(FieldSpec fiel

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456727715 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456539488 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456518529 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456450107 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -492,74 +327,51 @@ public int maxBytes() { } public

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456449035 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -492,74 +327,51 @@ public int maxBytes() { } public

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r456444794 ## File path: clients/src/main/resources/common/message/FetchResponse.json ## @@ -47,33 +47,35 @@ "about": "The top level response error code." },

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r455094448 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java ## @@ -273,6 +99,28 @@ public boolean equals(Object o) { }

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453849419 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2078,6 +2103,11 @@ private void generateFieldEquals(FieldSpe

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453849419 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2078,6 +2103,11 @@ private void generateFieldEquals(FieldSpe

[GitHub] [kafka] mumrah commented on a change in pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

mumrah commented on a change in pull request #9008: URL: https://github.com/apache/kafka/pull/9008#discussion_r453846799 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/RecordsReader.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundati