[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971306933 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -138,6 +139,15 @@ public List authorize( return results; }

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971116340 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -182,59 +174,58 @@ StandardAuthorizerData copyWithNewConfig(int nodeId,

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r971108745 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java: ## @@ -96,18 +97,16 @@ public void completeInitialLoad(Exception e) { }

[GitHub] [kafka] mumrah commented on a diff in pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-14 Thread GitBox
mumrah commented on code in PR #12636: URL: https://github.com/apache/kafka/pull/12636#discussion_r970977191 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -397,18 +387,34 @@ private MatchingAclRule findAclRule( return