[GitHub] [kafka] navina commented on pull request #8684: KAFKA-10012 Reducing memory overhead associated with strings in Metri…

2020-06-02 Thread GitBox
navina commented on pull request #8684: URL: https://github.com/apache/kafka/pull/8684#issuecomment-637827964 @ijuma I have removed the `intern()` calls. Please take a look. Thanks! This is an automated message from the Apa

[GitHub] [kafka] navina commented on pull request #8684: KAFKA-10012 Reducing memory overhead associated with strings in Metri…

2020-05-18 Thread GitBox
navina commented on pull request #8684: URL: https://github.com/apache/kafka/pull/8684#issuecomment-630444877 @ijuma What issues with intern are you referring to? I know that there can be a performance hit when there are a lot of intern strings. I believe string interning mechanism has bee