ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-760310777
Thanks @mimaison so much for your multiple rounds of valuable feedback and
comments which greatly improving the code quality of this PR
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-746543315
@mimaison thanks so much for all your efforts on reviewing. Really
appreciated if you may have time before end of this year to do 1-2 final
reviews to merge this PR.
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-742587762
@mimaison thanks so much for your careful review. I checked
https://github.com/apache/kafka/pull/9698 again and make sure we do not miss
anything at this moment.
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-742127747
@mimaison thanks for pointing out. Fixed the checkstyle, sorry for just
running the check for `connect/mirror`
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-741520739
@rhauch I incorporated https://github.com/apache/kafka/pull/9698 in my
latest version here
This is an
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-741395378
Hello @mimaison I addressed all your of comments, please take the final
review.
This is an automated
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-739114982
@rhauch if your pr is merged first, I will be happy to rebase on
https://github.com/apache/kafka/pull/9698
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-738115781
https://github.com/apache/kafka/pull/9224#discussion_r535179359
I think the `try catch` block is needed for several Exception.
```
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-731934229
@mimaison Thanks again for your previous detailed review. I updated the PR
to resolve the exact 2 concerns you raised.
Very appreciated for your another review!
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-731014605
Thanks @mimaison for your suggestive and insightful feedback.
Regarding to your 2 major concerns, I agree and I believe there exists a
feasible solution. I will
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-719201216
A kind reminder for additional feedback and comments, based on my response
above
This is an automated
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-714955565
Thanks @mimaison for your high-level advice and detailed review.
(1) I responded to your every comments. A "thumb-up" means I made the
suggested change
(2)
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-713306404
@edoardocomar @rhauch given this PR does not contain functional change and
have been pending over 45 days, could you please direct me to the right
reviewers to take a look?
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-707526684
Hello @mimaison @ryannedolan this PR does not contain any functional change,
it should be straightforward to review. Thanks for your time.
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-704353923
@mimaison I think this pr is ready for initial review. Please take your time
when available. Thanks
This is
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-703412889
./gradlew
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
@ryannedolan @mimaison when possible, very appreciated for your attentions
and feedback :) Thanks
This is
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-689622169
very appreciated for any feedback on what to test additionally and how to
get close to the real scenario. Some of the ideas come from
20 matches
Mail list logo
