[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1150022881 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -61,73 +83,250 @@ public void setup() { } @Test

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1148140557 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1146979021 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1146971049 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1146969176 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1146967451 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1144002857 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143999124 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143891018 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143888783 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143881070 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143865476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143865476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143739168 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143738304 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1140532145 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1140528394 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1140442417 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1140429707 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -116,12 +114,21 @@ private void maybeAutoCommit(final long

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139653568 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +223,209 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139651358 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +144,40 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139650990 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +144,40 @@ CompletableFuture sendAutoCommit(final Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139280595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139276421 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -80,16 +97,18 @@ public CommitRequestManager( */

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139257566 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136454999 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -437,29 +456,24 @@ public void wakeup() { */

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136454609 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136449438 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -306,13 +310,28 @@ public OffsetAndMetadata

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136434874 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +266,85 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136104123 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136096815 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -80,16 +97,18 @@ public CommitRequestManager( */

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1133442329 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1133441978 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1133346239 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/OffsetFetchApplicationEvent.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1133346162 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -437,29 +456,24 @@ public void wakeup() { */

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1133345989 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -306,13 +310,28 @@ public OffsetAndMetadata