[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-27 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1179185376 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,57 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1178121430 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1178034681 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void testPartitionsTransferrin

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177937393 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -42,10 +30,22 @@ import org.junit.jupiter.params.provider

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177936654 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void testPartitionsTransferrin

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177934535 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void testPartitionsTransferrin

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177895473 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177893519 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-25 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980677 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-25 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980400 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-19 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1172072549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-19 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171780417 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-19 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171712519 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-18 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170599794 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-18 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170098942 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-18 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170094810 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-18 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170094810 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-17 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1169135808 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-13 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165960472 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -153,43 +158,45 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-13 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165959573 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -153,43 +158,46 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-13 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165947809 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -16,6 +16,13 @@ */ package org.apache.kafka.clients.consume