subject:"\[GitHub\] \[kafka\] philipnee commented on a diff in pull request #14346\: KAFKA\-15115 \- KAFKA\-15163; Reset\/Validate positions implementation \& API integration"

[GitHub] [kafka] philipnee commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-08 Thread via GitHub

philipnee commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320241577 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -209,6 +215,34 @@ public ConsumerRecords poll(final Duration t

[GitHub] [kafka] philipnee commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub

philipnee commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1318977376 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -268,7 +326,7 @@ private CompletableFuture buildListOffsetRequ