philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1499289597
Hey @cadonna - sorry for the back and forth, your comment is addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1496380886
Thank you @cadonna - Based on your suggestions I configured the mockito
strictness based on your suggestion. I also cleaned the tests.
--
This is an automated message from the
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1495021777
Hey @cadonna - Again, thanks for the reviews; sorry for the auto-cleanup for
my IDE, I've cleaned up most of the unnecessary changes.
--
This is an automated message from the Apache
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1488874445
Not entirely sure what this is: `[2023-03-29T05:12:47.884Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-13269/core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:436:50:
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1486266466
Hey @cadonna - Thanks for getting back on this. I added two tests covering
EOS enabled/disabled cases - LMK if this is what you are looking for. I tried
to make the test case explicit
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453921659
i took a peek at it because @mjsax mentioned it is easy to work on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453919620
Oh yeah, I was wondering about that, too - it's up to you. We can abandon
this and wait for 10199 to be completed.
--
This is an automated message from the Apache Git Service.
To
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453776408
@cadonna - Thanks for the feedback there. I added the EOS check before the
checkpoint. I also made a bunch of changes to the tests. To make things
obvious, I added a comment to these
philipnee commented on PR #13269:
URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453770724
There's a bunch of failing DedicatedMirrorIntegrationTest - most likely
unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
