[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API

2023-03-28 Thread via GitHub
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1487707392 There's this weird failing test that I can't resolve. I think I might need to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API

2023-03-23 Thread via GitHub
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1482045502 Hey @guozhangwang sorry for going back and forth on this, I'll add some test cases to cover your comments. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] philipnee commented on pull request #13380: KAFKA-14468: Committed API

2023-03-17 Thread via GitHub
philipnee commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1474404071 Hey @guozhangwang - I think i've addressed most of your questions except merging the request classes. It is a bit difficult right now as we sometimes need to access the fields before