[GitHub] [kafka] philipnee commented on pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-20 Thread via GitHub
philipnee commented on PR #14386: URL: https://github.com/apache/kafka/pull/14386#issuecomment-1728753394 @junrao @lianetm - Thanks for another round of reviews. The latest build passed with the following test failures ``` Build / JDK 17 and Scala 2.13 / testBecomeFollowerWhileOld

[GitHub] [kafka] philipnee commented on pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on PR #14386: URL: https://github.com/apache/kafka/pull/14386#issuecomment-1724712594 @junrao @lianetm - I hope I've addressed most, if not all, comments that you pointed out. So, thank you both for reviewing my code. We did have an offline discussion about user AP

[GitHub] [kafka] philipnee commented on pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on PR #14386: URL: https://github.com/apache/kafka/pull/14386#issuecomment-1718779561 Hey @junrao - Addressed your comments. I'm holding off on your request for `Could we change toString to include the fields in the parent class?` as I think it would be easier if I do th