[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-03-07 Thread via GitHub
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1128069250 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -479,6 +489,42 @@ class DynamicBrokerConfigTest { assertEquals("User:admin",

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-02-06 Thread via GitHub
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1097911296 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-26 Thread via GitHub
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1088113461 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -392,14 +394,36 @@ class ControllerApis(val requestChannel: RequestChannel, val

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-13 Thread GitBox
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070162021 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -523,8 +523,23 @@ class ControllerApisTest { new

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-13 Thread GitBox
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070162021 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -523,8 +523,23 @@ class ControllerApisTest { new

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-13 Thread GitBox
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070011382 ## metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java: ## @@ -42,19 +45,39 @@ public static OptionalLong

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-13 Thread GitBox
rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r107035 ## docs/ops.html: ## @@ -1197,7 +1197,7 @@ - Client quotas: Kafka supports different types of (per-user principal) client quotas. Because a client's