[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102997944 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -0,0 +1,676 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102933380 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,19 +680,23 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProduc

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102914037 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -0,0 +1,676 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1102874502 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness { // get here w

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101431448 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101430927 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -680,20 +680,20 @@ class UnifiedLog(@volatile var logStartOffset: Long, } private[log] def activeProduc

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101429242 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -685,7 +685,7 @@ class TransactionsTest extends IntegrationTestHarness { // get here w

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1101428207 ## core/src/test/scala/unit/kafka/log/LogTestUtils.scala: ## @@ -247,7 +246,7 @@ object LogTestUtils { } def listProducerSnapshotOffsets(logDir: File): Seq[Long

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1072167191 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the interme

[GitHub] [kafka] satishd commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

satishd commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1072167191 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -191,7 +192,7 @@ class LogLoader( // Reload all snapshots into the ProducerStateManager cache, the interme