[GitHub] [kafka] satishd commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-04 Thread via GitHub
satishd commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284146317 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -623,10 +632,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

[GitHub] [kafka] satishd commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-03 Thread via GitHub
satishd commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1284030338 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata exten

[GitHub] [kafka] satishd commented on a diff in pull request #13984: KAFKA-15107: Support custom metadata for remote log segment

2023-08-03 Thread via GitHub
satishd commented on code in PR #13984: URL: https://github.com/apache/kafka/pull/13984#discussion_r1282146991 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -623,10 +632,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment