[GitHub] [kafka] satishd commented on a diff in pull request #14128: KAFKA-15272: Fix the logic which finds candidate log segments to upload it to tiered storage

2023-07-31 Thread via GitHub
satishd commented on code in PR #14128: URL: https://github.com/apache/kafka/pull/14128#discussion_r1280175519 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1002,4 +1004,36 @@ public void close() { } } +static class CandidateLogSegment

[GitHub] [kafka] satishd commented on a diff in pull request #14128: KAFKA-15272: Fix the logic which finds candidate log segments to upload it to tiered storage

2023-07-31 Thread via GitHub
satishd commented on code in PR #14128: URL: https://github.com/apache/kafka/pull/14128#discussion_r1280069565 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1002,4 +1004,36 @@ public void close() { } } +static class CandidateLogSegment

[GitHub] [kafka] satishd commented on a diff in pull request #14128: KAFKA-15272: Fix the logic which finds candidate log segments to upload it to tiered storage

2023-07-31 Thread via GitHub
satishd commented on code in PR #14128: URL: https://github.com/apache/kafka/pull/14128#discussion_r1280069565 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1002,4 +1004,36 @@ public void close() { } } +static class CandidateLogSegment