[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-28 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-907635550 Thanks @junrao for pointing that out. Earlier test failure is fixed with the latest commit and we do not see that failure now. The latest run failures are not related to the

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-27 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-907318976 Thanks @junrao for the comments. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-07-17 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-881843364 Thanks @junrao for the comment, replied inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-07-15 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-881150117 @junrao This is a minor refactoring. `SnapshotFile` can be reused by default RLMM for storing committed offsets for remote log metadata topic. -- This is an automated