[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426964876 Sorry for missed adding the reviewers section in the merge commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426961566 All the tests are passed, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-10 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1425587517 Thanks @showuon for your review. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-09 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1424157795 Thanks @ijuma for the review. Addressed them inline and/or with the latest commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-01-18 Thread GitBox
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1387574662 @ijuma It looks like the changes that were done in the conversions were accidentally dropped in my local repo while doing a few rebases and squashes with trunk and other changes. I

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-01-17 Thread GitBox
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1386596236 @ijuma It looks like the changes that were done in the conversions were accidentally dropped in my local repo while doing a few rebases in my trunk. I should have checked that before

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-01-17 Thread GitBox
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1385391553 Thanks @ijuma for the review comments. Addressed them inline and updated the PR with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the