[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

2023-02-22 Thread via GitHub
satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1440419578 A couple of test failures are not related to this change, will merge the changes to trunk. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

2023-02-20 Thread via GitHub
satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1437063403 Thanks @junrao @ijuma for your review. Addressed them with inline replies/commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

2023-02-18 Thread via GitHub
satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1435647234 >Are the test failures and timeout related to this PR? @junrao Those failures are not related to the PR. I pushed an empty commit to trigger the build/test jobs again. -- This is an

[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

2023-02-17 Thread via GitHub
satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1434476881 Thanks @junrao for the review. Addressed the review comments inline and/or updated with the latest commits. -- This is an automated message from the Apache Git Service. To respond to