[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r670111886 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandlerTest.java ## @@ -67,48 +69,88 @@ public voi

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r669472461 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandlerTest.java ## @@ -149,4 +191,21 @@ private v

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r669472287 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3359,23 +3360,23 @@ public void testDeleteConsumerGro

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r669471854 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -97,54 +108,79 @@ public String

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r669471550 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -97,54 +108,79 @@ public String

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-14 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r669471228 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -97,54 +108,79 @@ public String

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668787834 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668780259 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-12 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r667675187 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3345,12 +3345,9 @@ public void testDeleteConsumerGrou

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-12 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r667673170 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-11 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r667672477 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri