[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-04-05 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1158148779 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -147,6 +152,16 @@ private List removeWhileMatching(Iterator

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-04-05 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1158149051 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -147,6 +152,16 @@ private List removeWhileMatching(Iterator

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-04-03 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1155878999 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/InMemoryLeaderEpochCheckpoint.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-04-03 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1155876324 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -383,21 +398,25 @@ public void clear() { // Visible for testin

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154310401 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -383,21 +398,25 @@ public void clear() { // Visible for testin

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154193013 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -383,11 +396,11 @@ public void clear() { // Visible for testin

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154178753 ## core/src/main/scala/kafka/log/remote/RemoteLogManager.scala: ## @@ -219,6 +221,29 @@ class RemoteLogManager(rlmConfig: RemoteLogManagerConfig, } } + /** +

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154178160 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -148,6 +151,16 @@ private List removeWhileMatching(Iterator removeW

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154172866 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/InMemoryLeaderEpochCheckpoint.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

2023-03-31 Thread via GitHub
showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1154172866 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/InMemoryLeaderEpochCheckpoint.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software F