[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-21 Thread via GitHub
showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1173462823 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-19 Thread via GitHub
showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1170939326 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-19 Thread via GitHub
showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1170888493 ## tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java: ## @@ -193,8 +181,7 @@ static String levelToString(String feature, short level) { static void

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-05 Thread via GitHub
showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1159239494 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] showuon commented on a diff in pull request #13459: KAFKA-14592: Move FeatureCommand to tools

2023-04-05 Thread via GitHub
showuon commented on code in PR #13459: URL: https://github.com/apache/kafka/pull/13459#discussion_r1159227186 ## tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java: ## @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *