[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1308148879 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-14 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1293071660 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-14 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1293066497 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, private def deleteOldSegments(predi

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-13 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1292935520 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, private def deleteOldSegments(predi

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-02 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1281657244 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -667,11 +675,323 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-02 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1281568519 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +625,230 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-02 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1209013637 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +629,192 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-25 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1205425110 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -618,6 +629,193 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-01 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1181545427 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -942,13 +974,19 @@ class UnifiedLog(@volatile var logStartOffset: Long, localLog.checkIfMemoryMapped

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-04-28 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1180121259 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -581,11 +588,18 @@ public void run() { if (isLeader()) { // Co