[GitHub] [kafka] showuon commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

showuon commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294181153 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -265,7 +266,12 @@ public Optional serverConfigName(String configName) {

[GitHub] [kafka] showuon commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

showuon commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294181153 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -265,7 +266,12 @@ public Optional serverConfigName(String configName) {

[GitHub] [kafka] showuon commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

showuon commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1294139696 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -454,54 +460,101 @@ public static void validateNames(Properties props) {

[GitHub] [kafka] showuon commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

showuon commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1293269490 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -265,7 +266,10 @@ public Optional serverConfigName(String configName) {