[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1314886326 ## clients/src/main/java/org/apache/kafka/common/requests/ControllerRegistrationRequest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1314398152 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312733661 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1312662157 ## metadata/src/main/java/org/apache/kafka/controller/Controller.java: ## @@ -390,6 +391,19 @@ CompletableFuture> createPartitions( boolean validateOnly

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1311398405 ## core/src/test/resources/log4j.properties: ## @@ -12,14 +12,14 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1311278157 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1311278157 ## core/src/main/scala/kafka/server/AuthHelper.scala: ## @@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) { } } + def