showuon commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180087325
Good point. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
showuon commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1180078726
@ijuma , thanks for the reminder. But I've checked and confirmed there is
already a unit test covered this change: `ConfigDefTest#testNiceMemoryUnits`. I
should have mentioned it in the
showuon commented on PR #12389:
URL: https://github.com/apache/kafka/pull/12389#issuecomment-1179899658
Failed tests are unrelated:
```
Build / PowerPC / Run PowerPC Build /
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
Build /
