[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652713031 @abbccdda , thanks for pointing out the duplicate line. I didn't notice it, My bad! I've fixed. Thanks. This is

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652177809 Thanks for the comments, @abbccdda . I've address your comments in this commit: https://github.com/apache/kafka/pull/8712/commits/4b57a606a3834323302b6d3d33ab95e5b88d183b

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 1. Return the `topicsNotReady` to `makeReady` including `tempUnknownTopics`, and not create topic

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-649896512 hi @abbccdda , Last night before I went to sleep, I kept thinking about your question: > Why do we need allTopicsToDescribe? Then I found my change has 1 small logic flaw,

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-649604155 hi @abbccdda , thanks for the comments. I've updated them in this commit: https://github.com/apache/kafka/pull/8712/commits/70d41212fe8a4d5055993c56e30c2342498e1664. Please help

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-648846927 Hi @ableegoldman , thanks for the good suggestion! I've updated in this commit: https://github.com/apache/kafka/pull/8712/commits/f378c34d10c57d796412ac946f867e5787f93af0. What

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-647885294 hi @abbccdda @ableegoldman , sorry, but this PR stays for a while, do you have other comments? Or should I find someone else to review? Thanks.

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-640396593 Thanks @abbccdda , I've address your review comments in this commit: https://github.com/apache/kafka/pull/8712/commits/0567ecbc82c01b0c6e596fe5c28918f3b530a263. Thank you.

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-635071774 Thanks, @ableegoldman . Take your time. :) This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-635002983 Hi @abbccdda @ableegoldman , please help review this PR. Thanks This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-632729141 Hi @ableegoldman , could you review this PR? Thanks. This is an automated message from the Apache Git Service. To