[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-30 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-701733581 @mjsax , no problem at all. Totally understand  This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-22 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-696467921 @mjsax , sorry, I found you're online now. So could you take a look again for the long pending PR? It's 2nd review, so it should be easier. Thanks.

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-21 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-696467921 @mjsax , sorry, I found you're online now. So could you take a look again for the long pending PR? It's 2nd review, so it should be easier. Thanks.

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-21 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-696467921 @mjsax , sorry, I found you're online now. So could you take a look again for the long pending PR? It's 2nd review, so it should be easier. Thanks.

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-14 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-691990481 @mjsax could you review this PR again? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-08 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-689196185 @mjsax could you review this PR again? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-03 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-686864215 `tests/Build/JDK 11` and `tests/Build/JDK 15` test passed This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-03 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-686345544 merge the latest trunk to have auto-build This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-01 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-684518374 @mjsax , I didn't see the Jenkins build results. Should we run again? Thanks. This is an automated message from

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-24 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-678959902 @mjsax , I've updated in this commit: https://github.com/apache/kafka/pull/9121/commits/b248ccc4f35ce6bb7ef865c65392710c1558ca20. Thanks.

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-18 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-675828368 @mjsax , could you review this small PR? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-04 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668954076 **JDK11: failed with system failure** * What went wrong: 03:15:27 Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed) **JDK14:

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-04 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668507540 @mjsax , could you review this PR to add tests? Thanks. This is an automated message from the Apache Git Service.