[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652177809 Thanks for the comments, @abbccdda . I've address your comments in this commit: https://github.com/apache/kafka/pull/8712/commits/4b57a606a3834323302b6d3d33ab95e5b88d183b

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady`

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady`

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-650135514 hi @abbccdda , I've fixed the issue. What I did in the final commit are: 0. Revert the unnecessary changes 1. Return the `topicsNotReady` to `makeReady`

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-649896512 hi @abbccdda , Last night before I went to sleep, I kept thinking about your question: > Why do we need allTopicsToDescribe? Then I found my change has 1 small

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-649896512 hi @abbccdda , Last night before I went to sleep, I kept thinking about your question: > Why do we need allTopicsToDescribe? Then I found my change has 1 small

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-648846927 Hi @ableegoldman , thanks for the good suggestion! I've updated in this commit: https://github.com/apache/kafka/pull/8712/commits/f378c34d10c57d796412ac946f867e5787f93af0.