[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616762075 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616759894 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java ## @@ -0,0 +1,849 @@ +/* + * Licensed to

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616758960 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -60,20 +83,44 @@ } private class

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614313362 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614312924 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +263,66 @@ private void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614312224 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +263,66 @@ private void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614304330 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614303123 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614114447 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -60,20 +82,41 @@ } private class

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614105673 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614098535 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611915606 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611915696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611882455 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611878043 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +246,66 @@ private void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610893784 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -161,7 +181,7 @@ public void process(final K

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891590 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -92,6 +113,10 @@ public void process(final K

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891253 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +45,32 @@ private final String

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610891116 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +132,40 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890964 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +246,66 @@ private void

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610890414 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSide.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610754025 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r610044912 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String