[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-28 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431653319 ## File path: connect/transforms/src/test/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKeyTest.java ## @@ -0,0 +1,99 @@ +/* + *

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-28 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431652348 ## File path: connect/transforms/src/test/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKeyTest.java ## @@ -0,0 +1,99 @@ +/* + *

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431308724 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/TopicNameMatches.java ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431305276 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKey.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-22 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r429081838 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/PredicatedTransformation.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-22 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r429072047 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -257,12 +273,25 @@ public boolean

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-22 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r429067483 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -257,12 +273,25 @@ public boolean

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-22 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r429066772 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -257,12 +273,25 @@ public boolean

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-22 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r429064491 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -257,12 +273,25 @@ public boolean