tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-635196787
@rhauch @kkonstantine thanks very much for making those fixes for me, I
appreciate the time that must've taken. I've made one more trivial correction
to the integration test.
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-634585597
Rebased for conflict.
@kkonstantine I've addressed those first comments, thanks! Still some work
on the integration test (not passing when run via gradle).
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-632551475
@C0urante thanks for the review, some excellent points there! I think an
integration test is a great idea, which I'll work on next. I've addressed all
your other comments.
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-631683003
@C0urante you might also want to take a look.
This is an automated message from the Apache Git Service.
To
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-631651186
Still need to review test coverage, but @kkonstantine, @mimaison, @bbejeck
you might want to give it an initial pass.
