[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2021-01-28 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-768920853 @hachikuji I included the comment from @skaundinya15 and changed the PR description to reflect the actual design choice. Let me know if that's ok for you. -

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2021-01-25 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-766978261 Hi @ryannedolan @hachikuji I'd like a definitive direction from you on this subject. Once again, I reiterate on my personal preference as expressed previously by @r

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2021-01-25 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-766978261 Hi @ryannedolan @hachikuji I'd like a definitive direction from you on this subject. Once again, I reiterate on my personal preference as expressed previously by @r

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-30 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-736079387 @ryannedolan I have a preference for your first suggestion (the one for which there is currently a code proposition) because it doesn't alter the behavior of MM2 in any way fo

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-25 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-733687425 @ryannedolan I'm fine with either solution you suggest. What's the next step here ? I'm happy to contribute but I need your help on which direction we should take. -

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-18 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-729529865 @hachikuji ready for review, I believe failed CI is unrelated This is an automated message from the Apache Git Ser

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-16 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-728593310 @ryannedolan @hachikuji If I understand correctly, when setting up a link A->B.enabled=true (with defaults settings regarding heartbeat), it creates a topic heartbeat which pr

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-16 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-728339571 Thank you for your help @hachikuji. I agree with your analysis and it kind of makes sense for most use-cases with 2-3 clusters as described in the original KIP. I also understa

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-13 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-726846099 After fixing the issue : [root@lnx001385 log]# cat kafka-mirror-maker.log | grep herder [2020-11-13 15:53:53,935] INFO creating herder for replica_CENTRAL->replica_Z