[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175425019 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175076558 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-21 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1173450470 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-21 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1173450470 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-20 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1172435439 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-19 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1171304080 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void handleRecord(