urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-776732944
@dajac I think I found the issue, pushed the fix. There was a typo in the
command arg names. Could not get to execute the tests locally yet.
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-776654342
@dajac Really appreciate your review, fixed the last couple of comments.
This is an automated message from the Ap
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-772586539
@dajac Thank you for your comments, finally managed to address them. Also
rebased the branch.
This is an automat
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-767459838
@dajac Fixed the compilation issues - there is a test failure, but I don't
think those are related to the change
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-766923270
@dajac Thank you for your review. Managed to work on this, and addressed
your points.
This is an automated messa
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-766923270
@dajac Thank you for your review. Managed to work on this, and addressed
your points.
This is an automated messa
urbandan commented on pull request #9430:
URL: https://github.com/apache/kafka/pull/9430#issuecomment-724629025
@dajac Thanks for the reminder, pushed a bunch of unit tests covering the
GetOffsetShell tool.
This is an automa
